Add security warning to mailbox docs#149295
Open
StanFromIreland wants to merge 1 commit intopython:mainfrom
Open
Add security warning to mailbox docs#149295StanFromIreland wants to merge 1 commit intopython:mainfrom
mailbox docs#149295StanFromIreland wants to merge 1 commit intopython:mainfrom
Conversation
Documentation build overview
|
sethmlarson
approved these changes
May 2, 2026
bitdancer
requested changes
May 2, 2026
|
|
||
| The :mod:`!mailbox` module assumes full control over input parameters and the | ||
| underlying mailbox storage; it does not protect against untrusted paths or | ||
| externally modified data. |
Member
There was a problem hiding this comment.
Well, you could probably add a variation on this warning to every module in the stdlib that operates on files, so at the moment I'm not convinced. I haven't read over the security issues, though, so we'll see. I don't think the message as is is all that useful, though. I certainly don't know what it is trying to tell me.
I suggest we hold on this for a bit for further discussion.
|
When you're done making the requested changes, leave the comment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @bitdancer, you should have gotten a series of notifications just there. I suggest adding a security warning, they collectively are the motivation for this change.